From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 21 Sep 2011 20:37:06 +0000 (+0200)
Subject: st: Fix crash in theme-node-transition
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~7546
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8bd5b1e696e47ceedfb77f48128b2cc16c73c922;p=gnome-shell.git

st: Fix crash in theme-node-transition

Setting up the framebuffers for transitions may fail, in which case
the material used for drawing is left uninitialized, so trying to
access it results in a crash.
Instead bail out in this case, which means that we won't paint
anything during the transition - still, drawing errors are better
than crashes ...

https://bugzilla.gnome.org/show_bug.cgi?id=659676
---

diff --git a/src/st/st-theme-node-transition.c b/src/st/st-theme-node-transition.c
index 3da45ae05..7bb83cd91 100644
--- a/src/st/st-theme-node-transition.c
+++ b/src/st/st-theme-node-transition.c
@@ -328,6 +328,9 @@ st_theme_node_transition_paint (StThemeNodeTransition *transition,
 
       calculate_offscreen_box (transition, allocation);
       priv->needs_setup = !setup_framebuffers (transition, allocation);
+
+      if (priv->needs_setup) /* setting up framebuffers failed */
+        return;
     }
 
   cogl_color_set_from_4f (&constant, 0., 0., 0.,